This repository was archived by the owner on Feb 25, 2025. It is now read-only.
removed forbidden skia include#38761
Merged
gaaclarke merged 2 commits intoJan 11, 2023
Merged
Conversation
| #include "flutter/testing/assertions_skia.h" | ||
| #include "flutter/testing/test_gl_surface.h" | ||
| #include "flutter/testing/testing.h" | ||
| #include "impeller/renderer/backend/gles/gles.h" |
Contributor
There was a problem hiding this comment.
Can this be included directly from a GLES header instead of going through an Impeller internal header?
Contributor
Author
There was a problem hiding this comment.
Yep done. I thought there would be magic for opengl es vs opengl. This works too.
jason-simmons
approved these changes
Jan 11, 2023
This was referenced Jan 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes flutter/flutter#118280
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.