This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add React Native spring animation lib (1 of 2)#38733
Closed
CoolDude53 wants to merge 3 commits into
Closed
Conversation
Contributor
Author
|
@luckysmg once this is merged, I can go ahead with the second PR |
8 tasks
Contributor
Author
|
not sure how to make the license bot happy 😬 |
luckysmg
reviewed
Jan 10, 2023
| ORIGIN: ../../../third_party/react-native/LICENSE | ||
| TYPE: LicenseType.mit | ||
| FILE: ../../../third_party/react-native/Libraries/Animated/animations/SpringAnimation.js | ||
| ----------------------------------------------------------------------------------------------------MIT License |
Contributor
There was a problem hiding this comment.
maybe just ---------------------------------------------------------------------------------------------------- ?
Why there is a MIT License trailing? I didn't find this trailing in others.... 🤔
Contributor
Author
There was a problem hiding this comment.
ah, that might be it, just pushed...we'll see!
Contributor
|
We'll need to update the license script. Probably easiest if I just do it for you, one sec. |
8 tasks
Contributor
|
I got all confused by git and failed to update this PR, so instead I created a new PR: #38750 Sorry about that. I'll close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #37604
Adding React Native spring animation code and license (as is).
Part 1 of 2 per #37604 (comment)
List which issues are fixed by this PR. You must list at least one issue.
flutter/flutter#105687 (comment)
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.