Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Correct FrameTimingRecorder's raster start time.#38674

Merged
auto-submit[bot] merged 7 commits into
flutter-team-archive:mainfrom
luckysmg:frame_timing_fix
Jan 13, 2023
Merged

Correct FrameTimingRecorder's raster start time.#38674
auto-submit[bot] merged 7 commits into
flutter-team-archive:mainfrom
luckysmg:frame_timing_fix

Conversation

@luckysmg

@luckysmg luckysmg commented Jan 6, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fix:

The code

auto frame = surface_->AcquireFrame(layer_tree.frame_size());

could be very time-consuming sometimes. I think we should record it into raster time. So that we can observe this correctly using DevTools or addTimingCallback of framework side.

Preview

DevTools

Before patch:

Before.mp4

After patch:

After.mp4

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@flutter-dashboard

flutter-dashboard Bot commented Jan 6, 2023

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@luckysmg luckysmg requested a review from dnfield January 6, 2023 09:26
@luckysmg luckysmg changed the title Fix FrameTimingRecorder's raster start time correctly. Fix FrameTimingRecorder's raster start time. Jan 7, 2023
@luckysmg luckysmg requested a review from chinmaygarde January 7, 2023 09:42
@luckysmg luckysmg changed the title Fix FrameTimingRecorder's raster start time. Correct FrameTimingRecorder's raster start time and add missing trace events. Jan 8, 2023
@luckysmg luckysmg changed the title Correct FrameTimingRecorder's raster start time and add missing trace events. Correct FrameTimingRecorder's raster start time. Jan 8, 2023
@achillelrc

achillelrc commented Jan 9, 2023

Copy link
Copy Markdown

looks promising bro thanks for the work @luckysmg

@luckysmg luckysmg mentioned this pull request Jan 10, 2023
Closed
14 tasks
@luckysmg luckysmg self-assigned this Jan 13, 2023
@luckysmg luckysmg added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 13, 2023
@auto-submit auto-submit Bot merged commit 99509a7 into flutter-team-archive:main Jan 13, 2023
@luckysmg luckysmg mentioned this pull request Jan 13, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 13, 2023
Merged
This was referenced Jan 13, 2023
Merged
Merged
@gaaclarke gaaclarke mentioned this pull request Jan 13, 2023
Closed
@luckysmg luckysmg mentioned this pull request Jan 31, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dnfield dnfield Awaiting requested review from dnfield
1 more reviewer
@chinmaygarde chinmaygarde chinmaygarde approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@luckysmg luckysmg

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@luckysmg @achillelrc @chinmaygarde