Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Roll quiver to 3.2.1#38609

Closed
mit-mit wants to merge 1 commit into
flutter-team-archive:mainfrom
mit-mit:rollquiver
Closed

Roll quiver to 3.2.1#38609
mit-mit wants to merge 1 commit into
flutter-team-archive:mainfrom
mit-mit:rollquiver

Conversation

@mit-mit

@mit-mit mit-mit commented Jan 3, 2023

Copy link
Copy Markdown
Contributor

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

Need to roll quiver to a version that doesn't depend on BidirectionalIterator, which is being removed in https://dart-review.googlesource.com/c/sdk/+/276741?tab=checks.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@mit-mit mit-mit requested review from akbiggs and yjbanov January 3, 2023 13:03
@mit-mit

mit-mit commented Jan 3, 2023

Copy link
Copy Markdown
Contributor Author

cc @lrhn

@yjbanov

yjbanov commented Jan 3, 2023

Copy link
Copy Markdown
Contributor

We might need @cbracken's and/or @Hixie's help to figure out what to do about the NOTICE file.

@mit-mit

mit-mit commented Jan 4, 2023

Copy link
Copy Markdown
Contributor Author

Replaced by #38617

@mit-mit mit-mit closed this Jan 4, 2023
@mit-mit mit-mit deleted the rollquiver branch January 4, 2023 13:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants