Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[CP] [Impeller] Fixes for rendering issues in flutter-3.6-candidate.0#37558

Merged
zanderso merged 2 commits into
flutter-team-archive:flutter-3.6-candidate.0from
zanderso:impeller-fixes
Nov 16, 2022
Merged

[CP] [Impeller] Fixes for rendering issues in flutter-3.6-candidate.0#37558
zanderso merged 2 commits into
flutter-team-archive:flutter-3.6-candidate.0from
zanderso:impeller-fixes

Conversation

@zanderso

Copy link
Copy Markdown
Contributor

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdero

bdero commented Nov 12, 2022

Copy link
Copy Markdown
Contributor

We might want to also throw #37561 into the mix. I think the reason we haven't noticed it yet is that the default CTM is nearly always scaled up a bit on high DPI devices. For example, on my iPhone 12 Mini, the CTM gets scaled up by 3x on all of the DisplayLists that Impeller receives -- that leaves a buffer on the bottom and right sides of the layer and masks the problem for some appended scales and translations in the -x/-y direction.

@itsjustkevin

Copy link
Copy Markdown
Contributor

@zanderso did we want to add #37561 as referenced by @bdero?

@zanderso

Copy link
Copy Markdown
Contributor Author

@zanderso did we want to add #37561 as referenced by @bdero?

If that one is needed, I'll file a separate issue and PR for it. So it doesn't need to be included in this one.

@itsjustkevin

Copy link
Copy Markdown
Contributor

@godofredoc there seems to be an error in .ci.yaml from a change in 0075e10. Do you know how to resolve this so we can get this cherry pick in for the next beta?

@godofredoc

Copy link
Copy Markdown
Contributor

@godofredoc there seems to be an error in .ci.yaml from a change in 0075e10. Do you know how to resolve this so we can get this cherry pick in for the next beta?

The recipes branch was not created.

@godofredoc

Copy link
Copy Markdown
Contributor

@jonahwilliams would you mind rebasing the PR?

@godofredoc

Copy link
Copy Markdown
Contributor

@jonahwilliams would you mind rebasing the PR?

Sorry I meant to ask @zanderso

@zanderso

Copy link
Copy Markdown
Contributor Author

@jonahwilliams would you mind rebasing the PR?

Sorry I meant to ask @zanderso

Done.

@zanderso zanderso merged commit 521692a into flutter-team-archive:flutter-3.6-candidate.0 Nov 16, 2022
@zanderso zanderso deleted the impeller-fixes branch November 16, 2022 19:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

7 participants