Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Perform all iOS logging through ASL#3481

Merged
cbracken merged 2 commits into
flutter-team-archive:masterfrom
cbracken:all-asl-all-the-time
Mar 17, 2017
Merged

Perform all iOS logging through ASL#3481
cbracken merged 2 commits into
flutter-team-archive:masterfrom
cbracken:all-asl-all-the-time

Conversation

@cbracken

@cbracken cbracken commented Mar 16, 2017

Copy link
Copy Markdown
Contributor

As of iOS 10, ASL is deprecated and replaced with os_log. ASL calls
continue to result in logging but as of iOS 10.3, only ASL_LOG_NOTICE
level and above are logged by default.

This change partially reverts 2937f06,
adding back stdout and stderr redirection, which resulted in loss of
some direct writes to stdout that were necessary for debugging.

This change replaces the direct use of syslog with ASL on iOS, which
Apple has stated will continue to log on iOS >= 10. This eliminates the
need for the previous fwd-declaration of syslog.

As of iOS 10, ASL is deprecated and replaced with os_log. ASL calls
continue to result in logging but as of iOS 10.3, only ASL_LOG_NOTICE
level and above are logged.

This change partially reverts 2937f06,
adding back stdout and stderr redirection, which resulted in loss of
some direct writes to stdout that were necessary for debugging.

This change replaces the direct use of syslog with ASL on iOS, which
Apple has stated will continue to log on iOS >= 10. This eliminates the
need for the previous fwd-declaration of syslog.
@cbracken

Copy link
Copy Markdown
Contributor Author

Also eliminates an issue with Xcode-7-built framework running against iOS 10.2 physical devices.

Tested with Xcode 7 framework build; physically tested on iOS 10.2.1, iOS 10.3b7 (today's release) devices, iOS 9.3 simulator.

@cbracken cbracken closed this Mar 16, 2017
@cbracken cbracken deleted the all-asl-all-the-time branch March 16, 2017 20:31
@cbracken cbracken restored the all-asl-all-the-time branch March 17, 2017 00:32
@cbracken cbracken reopened this Mar 17, 2017
@cbracken

Copy link
Copy Markdown
Contributor Author

@chinmaygarde

@cbracken cbracken merged commit 24d9d25 into flutter-team-archive:master Mar 17, 2017
@cbracken cbracken deleted the all-asl-all-the-time branch March 17, 2017 01:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

3 participants