Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "Reland "Listen for Vsync callback on the UI thread directly""…#31786

Merged
renyou merged 2 commits into
flutter-team-archive:flutter-2.12-candidate.3from
renyou:flutter-2.12-candidate.3
Mar 3, 2022
Merged

Revert "Reland "Listen for Vsync callback on the UI thread directly""…#31786
renyou merged 2 commits into
flutter-team-archive:flutter-2.12-candidate.3from
renyou:flutter-2.12-candidate.3

Conversation

@renyou

@renyou renyou commented Mar 3, 2022

Copy link
Copy Markdown
Contributor

Cherry pick this revert to unblock internal roll.

@flutter-dashboard

Copy link
Copy Markdown

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@GaryQian GaryQian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@renyou renyou added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 3, 2022
@fluttergithubbot

Copy link
Copy Markdown
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux Unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 3, 2022
@renyou renyou merged commit 32395e4 into flutter-team-archive:flutter-2.12-candidate.3 Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

5 participants