fix the bounds of nested save layers with a mix of clips and transforms#31440
Conversation
|
This pull request was opened against a branch other than main. Since Flutter pull requests should not normally be opened against branches other than main, I have changed the base to main. If this was intended, you may modify the base back to flutter-2.8-candidate.16. See the Release Process for information about how other branches get updated. Reviewers: Use caution before merging pull requests to branches other than main, unless this is an intentional hotfix/cherrypick. |
|
Gold has detected about 1 new digest(s) on patchset 1. |
zanderso
left a comment
There was a problem hiding this comment.
It looks like the presubmit checks aren't using the right version of the recipes for this branch, which I think is causing the redness.
|
One of the failures was fixed by a re-run, but the MHE continues to fail getting some sort of stream path. |
Seems like we need an additional cherry-pick that includes |
Do the 2.8 recipe versions refer to that script? I'm confused, I think. Why would this cherry-pick have triggered the need for |
I agree. I don't see how my changes should have induced any dependency changes. |
I think I found the issue, sending a PR in the recipes branch to fix it. |
Here is the CL fixing the issue https://flutter-review.googlesource.com/c/recipes/+/26922 |
|
Do I need to rebase, or will the rerun pick up the new scripts? |
|
I believe the re-run will pick up the new recipe. |
|
I'm not sure when the re-run was started, but it failed again with the same error. |
|
Whoops. The last re-run started at 3:30pm, but the recipe change didn't actually land until 3:40pm. |
Running on half capacity has increased mac latency to ~1H |
|
The run started at 5:22 also failed. |
It appears that the presubmit check is not using the branched recipe. /cc @godofredoc |
Yeah this is actually an error in the retry logic. I'll open a bug to track. |
|
@zanderso am I missing a reason why we are trying to do a PR directly to the release branch? This is not the typical flow, please let me know if I am missing something. |
|
The PR against master does not merge cleanly against the branch, so @flar prepared this PR against the branch to try to make the cherry-pick easier. |
Cherry pick of #31437 to the flutter-2.8-candidate.16 base.