This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix a11y tab traversal#25401
Closed
yjbanov wants to merge 2 commits into
Closed
Conversation
goderbauer
reviewed
Apr 8, 2021
goderbauer
left a comment
Contributor
There was a problem hiding this comment.
(haven't looked at the web_UI code in detail since I am not too familiar with that one...)
| }) { | ||
| assert( | ||
| SemanticsFlag.isTextField.index & flags == 0 || editableTextId != null, | ||
| 'Text field semantics node must provide a non-ull editableTextId', |
| @@ -0,0 +1,70 @@ | |||
| :: felt_windows: a command-line utility for Windows for building and testing | |||
Contributor
There was a problem hiding this comment.
Are these changes supposed to be in this PR? They seem unrelated?
Contributor
There was a problem hiding this comment.
Some of the other files as well...
Contributor
Author
There was a problem hiding this comment.
Yeah, feel free to ignore. I will split this up into multiple PRs. Just sent this draft hastily as I was rushing out the door for vacation :-)
Contributor
Author
|
Closing this in favor of #25797. The new PR does not require framework-side changes. Will be ready for review probably later today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix widget traversal when using the TAB key while a11y is enabled.
editableTextId(added in add editableTextId - a stable unique TextEditable identifier flutter/flutter#79683) to synchronize theflutter/textinputchannel with the semantics tree by queuing commands until an<input>element is available.tabindex=0onto tappable targets, otherwise the browser doesn't treat the element as focusable.Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.