Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Use runes to get code units in CanvasKit. (#24024)#24144

Closed
harryterkelsen wants to merge 1 commit into
flutter-team-archive:flutter-1.26-candidate.17from
harryterkelsen:flutter-1.26-candidate.17
Closed

Use runes to get code units in CanvasKit. (#24024)#24144
harryterkelsen wants to merge 1 commit into
flutter-team-archive:flutter-1.26-candidate.17from
harryterkelsen:flutter-1.26-candidate.17

Conversation

@harryterkelsen

Copy link
Copy Markdown
Contributor

Cherry-picks #24024 into 1.26.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard

Copy link
Copy Markdown

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@christopherfujino

Copy link
Copy Markdown
Contributor

I applied this diff to #24142 so I'm going to close this PR. Thanks @hterkelsen

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

2 participants