Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[flutter_releases] Fix build error #22950

Merged
christopherfujino merged 7 commits into
flutter-team-archive:flutter-1.22-candidate.12from
cyanglaz:co_platform_view_reset
Dec 9, 2020
Merged

[flutter_releases] Fix build error #22950
christopherfujino merged 7 commits into
flutter-team-archive:flutter-1.22-candidate.12from
cyanglaz:co_platform_view_reset

Conversation

@cyanglaz

@cyanglaz cyanglaz commented Dec 9, 2020

Copy link
Copy Markdown
Contributor

@flutter-dashboard

Copy link
Copy Markdown

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.22-candidate.12. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard Bot changed the base branch from flutter-1.22-candidate.12 to master December 9, 2020 00:06
@google-cla google-cla Bot added the cla: yes label Dec 9, 2020
@cyanglaz cyanglaz changed the base branch from master to flutter-1.22-candidate.12 December 9, 2020 00:06
Chris Yang added 2 commits December 8, 2020 16:08
@christopherfujino

Copy link
Copy Markdown
Contributor

@cyanglaz

cyanglaz commented Dec 9, 2020

Copy link
Copy Markdown
Contributor Author

@christopherfujino it was a wrong fix, pushed again.

@christopherfujino

Copy link
Copy Markdown
Contributor

I triggered another LED build https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/fujino_google.com/342a1f37debe81e0f1ee1bcf32c10620f08bb403abcf267ebe145f55cb3a6424/+/annotations, and I'm seeing a different failure, this time in "Scenario App Integration Tests". I will follow up tomorrow.

@cyanglaz

cyanglaz commented Dec 9, 2020

Copy link
Copy Markdown
Contributor Author

@christopherfujino The test didn't fail locally, It is possibly a flake. Could you trigger another build and check?

@christopherfujino

Copy link
Copy Markdown
Contributor

@christopherfujino The test didn't fail locally, It is possibly a flake. Could you trigger another build and check?

Will do. cc @blasten in case this is expected to fail.

@christopherfujino

Copy link
Copy Markdown
Contributor

Ok, it passed on a re-run.

@christopherfujino christopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino

Copy link
Copy Markdown
Contributor

has the same CI failures as the previous PR on branch #22930, thus I am merging this to fix the Linux Android AOT Engine build.

@christopherfujino christopherfujino merged commit 27d74a3 into flutter-team-archive:flutter-1.22-candidate.12 Dec 9, 2020
@christopherfujino

Copy link
Copy Markdown
Contributor

Mac Stable iOS Engine flaked post-submit, to fix, cherrypick https://github.com/flutter/engine/pull/22247/files

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

2 participants