This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Start an engine in ShellTest.OnServiceProtocolGetSkSLsWorks#20801
Closed
jason-simmons wants to merge 1 commit into
Closed
Start an engine in ShellTest.OnServiceProtocolGetSkSLsWorks#20801jason-simmons wants to merge 1 commit into
jason-simmons wants to merge 1 commit into
Conversation
This test invokes a service protocol handler, and related methods such as Shell::GetServiceProtocolDescription make the assumption that an engine is available. See flutter-team-archive#20142
liyuqian
approved these changes
Aug 26, 2020
liyuqian
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks for the quick fix!
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test invokes a service protocol handler, and related methods such
as Shell::GetServiceProtocolDescription make the assumption that an
engine is available.
See #20142