This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix ViewRootImpl crash when using AndroidView on some brand devices#17611
Closed
dotcink wants to merge 1 commit into
Closed
Fix ViewRootImpl crash when using AndroidView on some brand devices#17611dotcink wants to merge 1 commit into
dotcink wants to merge 1 commit into
Conversation
01f192d to
9fedd66
Compare
9fedd66 to
cc66583
Compare
Contributor
|
Thanks for your PR! After testing it, it caused the old contents to stop playing when this was called, though it does prevent the crash. I worked with it some more and came up with #17897 which is able to fix the crash without the new stop-playing bug. |
Author
This is more reasonable, though I've not encountered this bug. |
Contributor
|
FYI. #17897 has landed in the engine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix flutter/flutter/issues/47154, flutter/flutter/issues/26345
Tested on
webview_flutterplugin).When soft keyboard shows/hides,
VirtualDisplayController.resize()is called, andSingleViewPresentationwould be recreated,then the deprecated
presentationSHOULD becanceled, which would callViewRootImpl.unscheduleTraversals(), before at most 1ViewRootImpl.performTraversals()calls, which are triggered byscheduleTraversals().Actually, after resize, the first
performTraversals()would makemDisplayfield null, and the second would crash withNullPointerException.