This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix double subscription to on/off label accessibility notification.#12464
Closed
brandondiamond wants to merge 1 commit into
Closed
Fix double subscription to on/off label accessibility notification.#12464brandondiamond wants to merge 1 commit into
brandondiamond wants to merge 1 commit into
Conversation
Contributor
|
#12404 had to be reverted. You may apply this change when when we attempt to reland that patch. |
Contributor
|
I've added a comment to the original PR and unchecked the fact that it has landed on flutter/flutter#43041. Given that the reverted PR hasn't landed yet, let's close this for now. Whoever re-lands it can remove the duplicate based on the comment on the original. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An extra subscription was accidentally added in #12404. This will cause onAccessibilityStatusChanged to be invoked an extra time (it isn't an error to subscribe twice, but this is nonetheless suboptimal).
This removes the extraneous subscription.