This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 5 commits
- 16 files changed
- 5 contributors
Commits on Aug 26, 2024
-
Ensure orchestrators aren't assigned to 32 core machines (#54754)
#54747 worked, so I'm going to apply that change to all builders on main, and then we can CP it into the release branches. For flutter/flutter#152186
-
[ios] Fix text input edit rotor accessibility (#54351)
Fixes text input edit rotor accessibility missing edit actions. It also fixes a few edit items that is displayed where it's not supposed to. (e.g. displaying select item while nothing to select). *List which issues are fixed by this PR. You must list at least one issue.* Fixes flutter/flutter#151029 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
-
Use GNI group instead of hardcoding PNG codecs source files. (#54781)
Fixes https://issues.skia.org/issues/362267329. The indirection introduced by this PR insulates Flutter from source-file-list changes in Skia. See the linked bug for more details. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
-
Change the
ci/analyze.shscript to analyze _all_ of the engine (#54779) Closes flutter/flutter#152636. As of this PR, we no longer cherry-pick specific directories to run `dart analyze` on. A few trailing errors across the repo had to be fixed in this PR.
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff f645ca5d8433...b41ca79092e8