Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter-team-archive/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f331e0afaf2e
Choose a base ref
...
head repository: flutter-team-archive/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: bec0dacaae41
Choose a head ref
  • 6 commits
  • 24 files changed
  • 5 contributors

Commits on Nov 22, 2023

  1. Roll Skia from 30ecaac60b47 to 3a79d7a618aa (1 revision) (#48328)

    https://skia.googlesource.com/skia.git/+log/30ecaac60b47..3a79d7a618aa
    
    2023-11-22 johnstiles@google.com Replace STArray with trivial hand-written stack.
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC brianosman@google.com,jacksongardner@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Nov 22, 2023
    Configuration menu
    Copy the full SHA
    78fd6de View commit details
    Browse the repository at this point in the history
  2. Delete unused/test only code from FML (#48327)

    This is more-or-less a revert of #14011
    
    This code never ended up being used outside of tests, and it's not how we handle asset loading at this point anyway.
    
    I was hopeful we could kill off all runtime dependencies on Dart in `FML` when looking at this, but it looks like trace_event.h still wants to import dart_api_tools.h for some Dart enum types. This may or may not matter if we ever want to build FML for web/wasm. /cc @eyebrowsoffire. If we really need to do that, we can refactor the trace event stuff so that it has a web and Dart implementation that's selected at build time.
    dnfield authored Nov 22, 2023
    Configuration menu
    Copy the full SHA
    0419b81 View commit details
    Browse the repository at this point in the history
  3. Fix Share Screen Crash on iPad (#48220)

    Fixes flutter/flutter#138550
    
    ![Simulator Screenshot - iPad Air (5th generation) - 2023-11-21 at 03 33 37](https://github.com/flutter/engine/assets/36148254/15e10e43-816b-43b1-a5ab-75c8add90899)
    LouiseHsu authored Nov 22, 2023
    Configuration menu
    Copy the full SHA
    2bd675c View commit details
    Browse the repository at this point in the history
  4. Roll Skia from 3a79d7a618aa to 5606ef899116 (1 revision) (#48331)

    https://skia.googlesource.com/skia.git/+log/3a79d7a618aa..5606ef899116
    
    2023-11-22 jvanverth@google.com Reland "[graphite] Use colorspace matrix to handle RGB swizzle."
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC brianosman@google.com,jacksongardner@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Nov 22, 2023
    Configuration menu
    Copy the full SHA
    f0cdea3 View commit details
    Browse the repository at this point in the history
  5. [web] Hook the new JS API to the FlutterViewManager (#48283)

    - Auto-generate view IDs.
    - Views don't auto-register/auto-unregister anymore.
    - Remove `EnginePlatformDispatcher.registerView/unregisterView` methods.
    - Add `FlutterViewManager.createAndRegisterView/disposeAndUnregisterView/dispose` methods.
    - Hook the `addView`/`removeView` JS APIs to `FlutterViewManager`.
    mdebbar authored Nov 22, 2023
    Configuration menu
    Copy the full SHA
    5733891 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. Configuration menu
    Copy the full SHA
    bec0dac View commit details
    Browse the repository at this point in the history
Loading