Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter-team-archive/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cb37ebc81939
Choose a base ref
...
head repository: flutter-team-archive/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: dee90f16aacd
Choose a head ref
  • 3 commits
  • 9 files changed
  • 3 contributors

Commits on Oct 12, 2023

  1. [web] Stop using flutterViewEmbedder for platform views (#46046) 

    As of right now, there is an indirect link between `flutter/platform_views` messages and `flutterViewEmbedder`, expressed by the callback that's being passed to the `PlatformViewMessageHandler`.

This PR proposed making this relationship clear between `flutter/platform_views` and `implicitView` (i.e. the singleton `window`).

This PR also opens the path for each view to have its own `PlatformViewMessageHandler` instance.

Depends on #46044

Part of flutter/flutter#134443
    @mdebbar
    mdebbar authored Oct 12, 2023
    Configuration menu
    Copy the full SHA
    5e50c7c View commit details
    Browse the repository at this point in the history

  2. [fuchsia] Add fatal error for Vulkan failure (#46831) 

    This CL changes vkWaitForFences to cause a FATAL failure as we can't
recover from these errors.

Bug: b/297198565
    @uysalere
    uysalere authored Oct 12, 2023
    Configuration menu
    Copy the full SHA
    8717ba5 View commit details
    Browse the repository at this point in the history

  3. Roll Skia from 8b110fd65de9 to bf557aeaaef8 (1 revision) (#46853) 

    https://skia.googlesource.com/skia.git/+log/8b110fd65de9..bf557aeaaef8

2023-10-12 michaelludwig@google.com Revert "[graphite] Use hardware image tiling when not subsetting"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 12, 2023
    Configuration menu
    Copy the full SHA
    dee90f1 View commit details
    Browse the repository at this point in the history
Loading