Comparing changes

Closes flutter/flutter#147259. Changes: - Make sure the default of `kNearest` is used consistently - Partial revert of #40491, re-adding `kBase` - Added some documentation about relevant enums, and why the default is `kNearest` - Wired up `kBase` in the Metal, Vulkan, and OpenGLES backends Expecting an update to the `dart_ui_filter_quality_none` golden file: > ![Screenshot 2024-05-13 at 2 47 49â�¯PM](https://github.com/flutter/engine/assets/168174/68df4c1a-9b2b-4201-9a6c-f78361a5aa30) For breadcrumbs around the mapping, see flutter/flutter#148253.

https://skia.googlesource.com/skia.git/+log/d0d87c26b489..fad584324d85 2024-05-15 sunnyps@chromium.org graphite: Do not call virtual setBackendLabel in Resource constructor If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://dart.googlesource.com/sdk.git/+log/0b77fbab8cf5..1eec9de2f9c6 2024-05-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-155.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

On top of the `SemanticsObject` refactor #52729 migrate `SemanticsObject` and `FlutterSemanticsScrollView` to ARC. Part of flutter/flutter#137801.

https://skia.googlesource.com/skia.git/+log/fad584324d85..c0caf10486ce 2024-05-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 166c9d5d561d to 0a7ce7cacd1b (17 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://skia.googlesource.com/skia.git/+log/c0caf10486ce..b3aadd56d187 2024-05-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 724dbf0e90cb to e127b96b4799 (6 revisions) 2024-05-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from c8e24928e2f9 to a21a77992dab 2024-05-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from b43af3a7d497 to c8e24928e2f9 (9 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://skia.googlesource.com/skia.git/+log/b3aadd56d187..a9ba7411d4b2 2024-05-15 ccameron@chromium.org Reland: Add ISO 21496-1 gainmap parsing If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://dart.googlesource.com/sdk.git/+log/1eec9de2f9c6..7d9de0c0b231 2024-05-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-156.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://skia.googlesource.com/skia.git/+log/a9ba7411d4b2..4a7419d662d5 2024-05-15 robertphillips@google.com [graphite] Make MatrixConvolutionImageFilter stably keyed (take 2) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://skia.googlesource.com/skia.git/+log/4a7419d662d5..475559da107d 2024-05-15 egdaniel@google.com [Graphite] Don't set DawnTexture label if we only have a view. 2024-05-15 kjlubick@google.com Update Windows P400s to Windows 22H2 and latest driver 2024-05-15 armansito@google.com Revert "Reland: Add ISO 21496-1 gainmap parsing" 2024-05-15 armansito@google.com Revert "graphite: Do not call virtual setBackendLabel in Resource constructor" 2024-05-15 kjlubick@google.com [bazel] Add target for svg_writer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

This PR rolls in the buildroot to pick up flutter-team-archive/buildroot#858.

https://dart.googlesource.com/sdk.git/+log/7d9de0c0b231..f773d45634ed 2024-05-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-158.0.dev 2024-05-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-157.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…... (#52853) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1. Migrate TextInputSemanticsObject to ARC 2. Rename the Objective-C-only `accessibility_text_entry.*` files to `TextInputSemanticsObject.*` 3. Move `FlutterInactiveTextInput` interface from the header file into the implementation, the only place it's used. Blocked on `SemanticsObject` ARC migration #52824 Part of flutter/flutter#137801.

https://skia.googlesource.com/skia.git/+log/475559da107d..b9a304eb05d2 2024-05-15 ccameron@chromium.org SkJpegEncoder: Specify metadata segments explicitly If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comparing changes

Open a pull request

Commits on May 15, 2024

This comparison is taking too long to generate.

Uh oh!