Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter-team-archive/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a4b88a37d511
Choose a base ref
...
head repository: flutter-team-archive/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 08f9be3ab284
Choose a head ref
  • 5 commits
  • 32 files changed
  • 4 contributors

Commits on Jul 30, 2024

  1. Roll Dart SDK from 14b51d32e3a6 to e16dc217b1ac (1 revision) (#54221) 

    https://dart.googlesource.com/sdk.git/+log/14b51d32e3a6..e16dc217b1ac

2024-07-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-95.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    5162aba View commit details
    Browse the repository at this point in the history

  2. Do not disable partial repaint based on thread merging state (#54219) 

    Currently we force full repaint when thread merging is detected, but
that is not a good way to determine whether platform view is in
hierarchy when thread merging is no longer needed. Alternative solution
here makes the PlatformViewLayer force full repaint when diffing.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
    @knopp
    knopp authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    3b9c31f View commit details
    Browse the repository at this point in the history

  3. [engine] Split encode and submit into two different surface frame cal… 

    …lbacks. (#54200)

This makes it much easier to implement the deferred submit required for #53826
    Jonah Williams authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    909c28a View commit details
    Browse the repository at this point in the history

  4. Roll Skia from b9b208f11c67 to 4e31906b6312 (1 revision) (#54226) 

    https://skia.googlesource.com/skia.git/+log/b9b208f11c67..4e31906b6312

2024-07-30 johnstiles@google.com Add design doc links for go/sksl-rp.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    44dfaf3 View commit details
    Browse the repository at this point in the history

  5. [iOS] Delete unused create_ios_framework.py (#54227) 

    This script is unused and is superseded by create_full_ios_framework.py.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @cbracken
    cbracken authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    08f9be3 View commit details
    Browse the repository at this point in the history
Loading