Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter-team-archive/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 76a1c64f4e63
Choose a base ref
...
head repository: flutter-team-archive/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 971ddd9fe1bf
Choose a head ref
  • 6 commits
  • 2 files changed
  • 4 contributors

Commits on Aug 14, 2024

  1. Roll Fuchsia Linux SDK from MeV5i7xXXFPHF5sBK... to qpfC-GAVZvOwAQU5f…

    …... (#54559)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
    Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Aug 14, 2024
    Configuration menu
    Copy the full SHA
    f550375 View commit details
    Browse the repository at this point in the history
  2. macOS: Refactor create_macos_framework.py (#54557)

    This is a refactoring with no semantic changes.
    
    This refactors the macOS framework creation code to be more readable, and extracts it to `sky_utils.py`.
    
    While I was pulling this out, also generalised the code to not hardcode `FlutterMacOS.framework` in case we one day manage to generate the iOS and macOS frameworks with the same name.
    
    This is a reland of #54546 (reverted in #54549), the original was reverted in order to revert #54543 (reverted in #54550), which was reverted because it failed to preserve symlinks while zipping the macOS framework. That patch has been relanded with a fix in #54555. This patch has been rebased to tip-of-tree for attempt two.
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    cbracken authored Aug 14, 2024
    Configuration menu
    Copy the full SHA
    7949ab3 View commit details
    Browse the repository at this point in the history
  3. Roll Fuchsia Test Scripts from J1EXQ2ozMIQEa6F7H... to -XDS8eBA0Le-zC…

    …EfW... (#54561)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/fuchsia-test-scripts-flutter-engine
    Please CC chrome-fuchsia-engprod@google.com,zra@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Aug 14, 2024
    Configuration menu
    Copy the full SHA
    0f95d2d View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. [Impeller] migrate blur tests to display list. (#54519)

    Part of DL interop. Currently experiencing some ... issues with blur radius/sigma.
    EDIT: was rrect_blur vs gaussian: fixed now.
    Jonah Williams authored Aug 15, 2024
    Configuration menu
    Copy the full SHA
    d143913 View commit details
    Browse the repository at this point in the history
  2. Reverts "[Impeller] migrate blur tests to display list. (#54519)" (#5…

    …4564)
    
    Reverts: #54519
    Initiated by: jonahwilliams
    Reason for reverting: post submit golden issues.
    Original PR Author: jonahwilliams
    
    Reviewed By: {chinmaygarde}
    
    This change reverts the following previous change:
    Part of DL interop. Currently experiencing some ... issues with blur radius/sigma.
    EDIT: was rrect_blur vs gaussian: fixed now.
    
    Part of flutter/flutter#142054
    auto-submit[bot] authored Aug 15, 2024
    Configuration menu
    Copy the full SHA
    6a65b8c View commit details
    Browse the repository at this point in the history
  3. Reverts "macOS: Refactor create_macos_framework.py (#54557)" (#54566)

    Reverts: #54557
    Initiated by: zanderso
    Reason for reverting: Failing on framework tests on the roll https://ci.chromium.org/ui/p/flutter/builders/try/Mac_arm64%20run_debug_test_macos/9841/overview
    Original PR Author: cbracken
    
    Reviewed By: {jmagman}
    
    This change reverts the following previous change:
    This is a refactoring with no semantic changes.
    
    This refactors the macOS framework creation code to be more readable, and extracts it to `sky_utils.py`.
    
    While I was pulling this out, also generalised the code to not hardcode `FlutterMacOS.framework` in case we one day manage to generate the iOS and macOS frameworks with the same name.
    
    This is a reland of #54546 (reverted in #54549), the original was reverted in order to revert #54543 (reverted in #54550), which was reverted because it failed to preserve symlinks while zipping the macOS framework. That patch has been relanded with a fix in #54555. This patch has been rebased to tip-of-tree for attempt two.
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    auto-submit[bot] authored Aug 15, 2024
    Configuration menu
    Copy the full SHA
    971ddd9 View commit details
    Browse the repository at this point in the history
Loading