Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter-team-archive/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1089ce6874cf
Choose a base ref
...
head repository: flutter-team-archive/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a5f7d5d75ff2
Choose a head ref
  • 11 commits
  • 13 files changed
  • 8 contributors

Commits on Jun 7, 2023

  1. [Impeller] fix missing assignment of embedder render target. (#42630)

    Otherwise we can't render �
    Jonah Williams authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    52b94e4 View commit details
    Browse the repository at this point in the history
  2. [iOS] Fix TextInputAction.continueAction sends wrong action to framew…

    …ork (#42615)
    
    ## Description
    
    This PR fixes an issue related to text input plugin, on IOS, sending a wrong action string to the engine for `FlutterTextInputActionContinue`.
    
    ## Related Issue
    
    Fixes flutter/flutter#126922
    
    ## Tests
    
    Adds 1 test.
    bleroux authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    f330dd4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    329bff3 View commit details
    Browse the repository at this point in the history
  4. Roll Fuchsia Linux SDK from sEHtHM1iFt79roP-x... to aMTaMP0DdKdJnxSbc…

    …... (#42631)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
    Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    a0dee96 View commit details
    Browse the repository at this point in the history
  5. Roll Fuchsia Mac SDK from ojwVlxZWrbsG4WGSE... to DL1QQ5eZRVNARqLx-... (

    #42632)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
    Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    491a640 View commit details
    Browse the repository at this point in the history
  6. Add global test docs. (#42531)

    Adds documentation for the use cases supported by global tests along with their respective configurations.
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    godofredoc authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    4e5c53a View commit details
    Browse the repository at this point in the history
  7. Roll Skia from 773765ca1dd2 to c5a8c4547f59 (4 revisions) (#42633)

    https://skia.googlesource.com/skia.git/+log/773765ca1dd2..c5a8c4547f59
    
    2023-06-07 robertphillips@google.com Expand big image unit test
    2023-06-07 jvanverth@google.com [graphite] Clean up BackendTexture.
    2023-06-07 michaelludwig@google.com [skif] Update SkLocalMatrixImageFilter to FilterResult system
    2023-06-07 robertphillips@google.com Add unit test for large images (take 2)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC borenet@google.com,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    5a42b5f View commit details
    Browse the repository at this point in the history
  8. Roll dart to 3.1.0-171.0.dev (#42636)

    Changes since last dart-sdk roll
    ```
    5144119b99c (tag: 3.1.0-171.0.dev) Version 3.1.0-171.0.dev
    39de3f2e5bd Field promotion: track field accesses via SSA node.
    f180b7037c0 Shared analysis: remove bogus support for late variable patterns.
    5e5fe2aa773 [analyzer_cli] [dartdev] Fix several tests on Windows
    c739cbfd7b0 [analysis_server] Fix generation tests on Windows
    f984411eac1 [analysis_server] Fix split_multiple_declarations to use \r\n on Windows
    f2b845a77f4 (tag: 3.1.0-170.0.dev) Version 3.1.0-170.0.dev
    2a705d8612f [analysis_server] Extract base server functionality from protocol-specific callbacks
    ```
    aam authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    33c25fa View commit details
    Browse the repository at this point in the history
  9. [Impeller] Corrected the 'texture_coords' computation in 'Geometry::G…

    …etPositionUVBuffer' (#42619)
    
    fix flutter/flutter#128328
    
    We need to transform the 'position' first and then divide 'texture_coverage', otherwise the result will be incorrect.
    
    without patch
    ![66WTKLw7fY](https://github.com/flutter/engine/assets/31977171/6d31138e-0595-4d9c-883e-70a50a5e228d)
    with patch
    ![VAHrQB0HLk](https://github.com/flutter/engine/assets/31977171/0d75e2f8-126e-4ba0-8867-187a311249f4)
    ColdPaleLight authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    c9283a5 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    0fd8e1a View commit details
    Browse the repository at this point in the history
  11. Roll Skia from c5a8c4547f59 to 156542f8bf13 (4 revisions) (#42641)

    https://skia.googlesource.com/skia.git/+log/c5a8c4547f59..156542f8bf13
    
    2023-06-07 robertphillips@google.com Disable rotated nearest-neighbor testing in the big image test
    2023-06-07 johnstiles@google.com Emit simpler WGSL for-loops when the loop-count is known.
    2023-06-07 johnstiles@google.com Add WGSL support for the discard statement.
    2023-06-07 johnstiles@google.com Allow assignment to function parameters in WGSL.
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC borenet@google.com,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    a5f7d5d View commit details
    Browse the repository at this point in the history
Loading