Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter-team-archive/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0dfbd04106ed
Choose a base ref
...
head repository: flutter-team-archive/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 61616ace5fa8
Choose a head ref
  • 3 commits
  • 8 files changed
  • 3 contributors

Commits on Dec 16, 2024

  1. [web] Don't close image source too early (#57200) 

    A `CkImage` instance holds a reference to `ImageSource?`. When that `CkImage` gets cloned, the `ImageSource` instance becomes shared between the original `CkImage` and its new clone. Then when one of the `CkImage`s gets disposed of, it closes the shared `ImageSource` leaving other live `CkImage`s holding on to a closed `ImageSource`.

The quick solution to this is to have a ref count on the `ImageSource` to count how many `CkImage`s are referencing it. The `ImageSource` will only be closed if its ref count reaches 0.

Fixes flutter/flutter#160199
Fixes flutter/flutter#158093
    @mdebbar
    mdebbar authored Dec 16, 2024
    Configuration menu
    Copy the full SHA
    52664aa View commit details
    Browse the repository at this point in the history

  2. Flutter-GPU.md: Fix spelling (#57216) 

    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @domesticmouse
    domesticmouse authored Dec 16, 2024
    Configuration menu
    Copy the full SHA
    b94ce44 View commit details
    Browse the repository at this point in the history

  3. Migrate FlBinaryMessenger using embedder API instead of mock engine. (#… 

    …57214)

This allows us to remove most of the remaining mock engine code.
    @robert-ancell
    robert-ancell authored Dec 16, 2024
    Configuration menu
    Copy the full SHA
    61616ac View commit details
    Browse the repository at this point in the history
Loading