[Impeller] Make validation errors fatal in non-release builds. (#36812)

zanderso · web-flow · commit 8744c93c4d53 · 2022-10-17T22:46:37.000Z
diff --git a/impeller/base/validation.cc b/impeller/base/validation.cc
@@ -24,8 +24,12 @@ ValidationLog::ValidationLog() = default;
 
 ValidationLog::~ValidationLog() {
   if (sValidationLogsDisabledCount <= 0) {
+#if (FLUTTER_RUNTIME_MODE == FLUTTER_RUNTIME_MODE_RELEASE)
     FML_LOG(ERROR) << stream_.str();
     ImpellerValidationBreak();
+#else
+    FML_LOG(FATAL) << stream_.str();
+#endif
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -24,8 +24,12 @@ ValidationLog::ValidationLog() = default;`
`24`	`24`
`25`	`25`	`ValidationLog::~ValidationLog() {`
`26`	`26`	`if (sValidationLogsDisabledCount <= 0) {`
	`27`	`+#if (FLUTTER_RUNTIME_MODE == FLUTTER_RUNTIME_MODE_RELEASE)`
`27`	`28`	`FML_LOG(ERROR) << stream_.str();`
`28`	`29`	`ImpellerValidationBreak();`
	`30`	`+#else`
	`31`	`+ FML_LOG(FATAL) << stream_.str();`
	`32`	`+#endif`
`29`	`33`	`}`
`30`	`34`	`}`
`31`	`35`