Pay plugin#4
Conversation
- allow creating cards with token (Android only atm)
remonh87
left a comment
There was a problem hiding this comment.
for the rest looks good just check why those two files are not generated anymore
| @@ -1,761 +0,0 @@ | |||
| // GENERATED CODE - DO NOT MODIFY BY HAND | |||
There was a problem hiding this comment.
It is a bit suspicious that this is removed while we still use freezes in this file. Propably freeze code gen fails
There was a problem hiding this comment.
just forgot to commit them
| @@ -1,307 +0,0 @@ | |||
| // GENERATED CODE - DO NOT MODIFY BY HAND | |||
There was a problem hiding this comment.
Looks like payment method codegen fails here
# Conflicts: # stripe_platform_interface/lib/src/models/card_field_input.dart # stripe_platform_interface/lib/src/models/card_field_input.freezed.dart # stripe_platform_interface/lib/src/models/card_field_input.g.dart # stripe_platform_interface/lib/src/models/payment_methods.dart # stripe_platform_interface/lib/src/models/payment_methods.freezed.dart # stripe_platform_interface/lib/src/models/payment_methods.g.dart
| .setNumber(card.getString("number").orEmpty()) | ||
| .build() | ||
| if (card.hasKey("token")) { | ||
| return PaymentMethodCreateParams.Card.create(card.getString("token")) |
There was a problem hiding this comment.
I had to do `PaymentMethodCreateParams.Card.create(card.getString("token")!!) otherwise Android would throw a type mismatch error. Did you not get that build error?
There was a problem hiding this comment.
no, compiled and worked fine on the device for me with Android Studio 4.1.3
There was a problem hiding this comment.
The React Native project also? Looks like it might be related to RN
There was a problem hiding this comment.
Didn't know it was marked nullable on React Native - my bad
Can you quickly fix it? Otherwise I'll send a PR
There was a problem hiding this comment.
Oh yah, no worries, already done before merging: stripe/stripe-react-native@407fd89
Just wanted to flag with you in case it applied here also.
No description provided.