fix: add ProGuard rules to prevent 3D Secure crash#2320
Merged
remonh87 merged 1 commit intoFeb 3, 2026
Conversation
Add comprehensive ProGuard/R8 rules to the library's consumer rules to prevent PaymentFlowResult$Unvalidated$Companion from being stripped during minification. This fixes the crash that occurs after completing 3D Secure authentication on Android. Fixes flutter-stripe#2221
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PaymentFlowResult$Unvalidated$Companionfrom being stripped during minificationProblem
When using payment methods that require 3D Secure authentication (mandatory for many cards in EU/UK), the app crashes after the WebView closes with:
This happens because the library's
proguard-rules.txt(distributed viaconsumerProguardFiles) was missing the critical-keep class com.stripe.** { *; }rule, allowing R8/ProGuard to strip essential Stripe payment flow classes.Solution
Enhanced
packages/stripe_android/android/proguard-rules.txtto include:-keep class com.stripe.** { *; }- Keeps all Stripe classes-dontwarnrules for push provisioning and kotlinx.parcelizeThese rules are now automatically applied to consuming apps via
consumerProguardFiles, so users no longer need to manually add them.Fixes #2221
Test plan
4000 0027 6000 3184)