fix: change initCustomerSheet return type to Future<void>#2292
Merged
remonh87 merged 3 commits intoJan 14, 2026
Merged
Conversation
…ripe#2283) The method always returned null on success, making the CustomerSheetResult? return type misleading. This aligns with React Native SDK behavior. Changes: - Return type: Future<CustomerSheetResult?> → Future<void> - Simplified implementation to only check for errors - Added doc comment about throwing StripeException on failure
- Replace dart:js with dart:js_interop in loader tests - Add dart:js_interop_unsafe for bracket operator support - Update context to globalContext - Fix example .env import path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2283: The
initCustomerSheetmethod has a misleading return type.Problem
Future<CustomerSheetResult?>suggesting payment data might be returnednullon success, throws exception on errorPromise<{ error?: StripeError }>Solution
Future<void>StripeExceptionon failureChanges
stripe_platform_interface.dart- Updated interface signaturemethod_channel_stripe.dart- Simplified implementationstripe.dart- Updated public facadeweb_stripe.dart- Updated web implementationBreaking Change
This is a minor breaking change for any code that was capturing the (always null) return value. The fix is simple - just remove the variable assignment since the method now returns
void.Before:
After:
Test plan