Skip to content

Sync#2101

Merged
remonh87 merged 25 commits into
mainfrom
sync
Apr 3, 2025
Merged

Sync#2101
remonh87 merged 25 commits into
mainfrom
sync

Conversation

@remonh87

Copy link
Copy Markdown
Member

No description provided.

@remonh87 remonh87 requested a review from jonasbark March 16, 2025 20:27
@jonasbark

Copy link
Copy Markdown
Member

15d06dc fix: cardfield methods

@remonh87 this change was on purpose as Stripe changed it as well. Can you double check?

@remonh87

remonh87 commented Apr 3, 2025

Copy link
Copy Markdown
Member Author

15d06dc fix: cardfield methods

@remonh87 this change was on purpose as Stripe changed it as well. Can you double check?

@jonasbark yes I see that on Android but not on iOS as there it is still oncardchange:

func onCardChange(_ arguments: Dictionary<AnyHashable, Any>?) {
    channel.invokeMethod("onCardChange", arguments: arguments)
}

so shall we then fix it in Swift in our factory to keep it consistent?

@remonh87

remonh87 commented Apr 3, 2025

Copy link
Copy Markdown
Member Author

15d06dc fix: cardfield methods

@remonh87 this change was on purpose as Stripe changed it as well. Can you double check?

fixed

@remonh87 remonh87 merged commit afa3089 into main Apr 3, 2025
@jonasbark jonasbark deleted the sync branch May 29, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants