Adding a note about the Android Studio Flamingo gradle mismatch #8501

sfshaza2 · 2023-04-06T09:19:46Z

This PR supercedes PR #8490.

Staged here:
main page: https://parlough-android-flutter.web.app/
migration page: https://parlough-android-flutter.web.app/release/breaking-changes/android-java-gradle-migration-guide
the "go" link: https://parlough-android-flutter.web.app/go/android-java-gradle-error

(This is the staged go link. The actual go link will be docs.flutter.dev rather than parlough-android-flutter.web.app.)

@reidbaker @camsim99 @mariamhas @ericwindmill @redbrogdon @timsneath

khanhnwin · 2023-04-06T16:25:45Z

Dropping my ping to shams here for reference -- It looks like the image urls on this staging link is referencing localhost - so the local staging version might have been pushed to Firebase instead of the built static files! @sfshaza2 try running make build and then deploy to firebase again!

camsim99 · 2023-04-06T16:32:02Z

@sfshaza2 Was the go link go/android-android-gradle-error intended to be go/android-java-gradle-error?

firebase.json

src/release/breaking-changes/android-java-gradle-migration-guide.md

src/_includes/banner.html

src/release/breaking-changes/android-java-gradle-migration-guide.md

timsneath · 2023-04-06T17:17:38Z

src/release/breaking-changes/android-java-gradle-migration-guide.md

+  [splitting out ApplicationId from PackageName][].
+  If this occurs, downgrade to the 7.6 release of
+  Gradle.
+* If, as part of this fix, you upgraded to Flutter 3.10


This bullet seems completely orthogonal, no? Upgrading to Flutter 3.10 is not connected to upgrading Android Studio.

Yeah, I'm just a tad worried that folks might upgrade to 3.10 (thinking it might help), and then be really screwed. Especially because there is a new command in 3.10 which tells you if you have this incompatibility situation.

I'd be more explicit then, I think. Rather than saying "as part of this fix", should we simply say "upgrading to Flutter 3.10 does not fix this problem"?

src/release/breaking-changes/android-java-gradle-migration-guide.md

timsneath · 2023-04-06T17:18:26Z

src/release/breaking-changes/android-java-gradle-migration-guide.md

+updates the Java SDK from 11 to 17, which
+isn't compatible with the version of the Java SDK
+used to build the app's Gradle file when the project
+was originally created with `flutter create`.


Long run-on sentence?

Co-authored-by: Parker Lougheed <parlough@gmail.com>

…de.md Co-authored-by: Parker Lougheed <parlough@gmail.com>

ericwindmill

The instructions worked and are easy to follow.

src/release/breaking-changes/android-java-gradle-migration-guide.md

mariamhas · 2023-04-06T19:43:19Z

src/release/breaking-changes/android-java-gradle-migration-guide.md

+    shell script's `JAVA_HOME` environment variable.
+  * If `JAVA_HOME` isn't defined, Flutter looks
+    for any `java` executable in your path.
+    Once [issue 122609][] lands, the `flutter doctor`


it is only landing for 3.10 right? or will anyone using flutter doctor in previous releases also get this fix so that they can depend on it?

it being issue 122609

??? I don't know what we advise here.

mariamhas · 2023-04-06T19:46:27Z

src/release/breaking-changes/index.md


 ### Not yet released to stable

+* [Android Java Gradle migration guide][]


hmm this feels weird to be under not yet release to stable, currently there is nothing in the guide that depends on the next stable release for developers to follow it and unblock themselves when using Flamingo.

if we add the flutter analyze --suggestions tool steps into the guide then it has something that is not yet released to stable

Yeah. I can just take it out of the index.

src/release/breaking-changes/android-java-gradle-migration-guide.md

reidbaker · 2023-04-06T20:05:09Z

src/release/breaking-changes/android-java-gradle-migration-guide.md

+  change the `distributionUrl` field to the new Gradle version:
+
+```properties
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.0.2-all.zip 


I think we should suggest updating to a version that starts with 7 not the latest gradle.
This is for 2 reasons. In my own updates of our owned examples we have had fewer issues, sometimes non when updating to 7.3.3 (minimum) or 7.6.1 (newest 7.* version released in feb) and run into significantly more issues moving to 8.*.
Second is that the gradle tooling as a policy has one major version of depreciation cycle before removal. So assuming their gradle code did have something deprecated it is more likely to exist in major version 7 and removed in 8

Per https://gradle.org/whats-new/gradle-8/#upgrades, it looks like users should upgrade to 7.6.1 as an intermediary state, even if they're ultimately moving to 8.x -- so I agree that we should make that our target throughout this doc.

src/release/breaking-changes/android-java-gradle-migration-guide.md

sfshaza2 · 2023-04-06T23:28:07Z

@Updated. Please review again @timsneath @mariamhas @reidbaker

reidbaker · 2023-04-07T16:40:27Z

src/release/breaking-changes/android-java-gradle-migration-guide.md

+updates its bundled Java SDK from 11 to 17.
+Flutter uses the version of Java bundled with
+Android Studio to build Android apps.
+Gradle versions [prior to 7.3][] can't run


Is this supposed to have a link?

timsneath

This is looking great. Thank you so much for all your work to make this transition less painful for customers! I'm sure we'll keep tweaking this page over the coming week, but it's a solid LGTM from me!

Tim has given permission to do so.

sfshaza2 added 5 commits April 5, 2023 20:38

Stashing, so I can add pics in another PR.

231b4ba

Merge branch 'main' into flamingo

cfd5187

Stashing

60c3c6a

Merge branch 'main' into flamingo

73f8ee2

Adding info on the Android Studio Flamingo issue

ddfd98b

sfshaza2 requested review from atsansone, domesticmouse, johnpryan, khanhnwin and parlough as code owners April 6, 2023 09:19

domesticmouse approved these changes Apr 6, 2023

View reviewed changes

camsim99 mentioned this pull request Apr 6, 2023

Update re-thrown error for incompatible Java/Gradle versions to include migration guide flutter/flutter#124327

Merged

8 tasks

Merge branch 'main' into flamingo

e29f829

parlough reviewed Apr 6, 2023

View reviewed changes

firebase.json Outdated Show resolved Hide resolved

src/release/breaking-changes/android-java-gradle-migration-guide.md Show resolved Hide resolved

src/release/breaking-changes/android-java-gradle-migration-guide.md Outdated Show resolved Hide resolved

timsneath reviewed Apr 6, 2023

View reviewed changes

src/_includes/banner.html Show resolved Hide resolved

timsneath reviewed Apr 6, 2023

View reviewed changes

src/release/breaking-changes/android-java-gradle-migration-guide.md Outdated Show resolved Hide resolved

timsneath reviewed Apr 6, 2023

View reviewed changes

src/release/breaking-changes/android-java-gradle-migration-guide.md Outdated Show resolved Hide resolved

timsneath reviewed Apr 6, 2023

View reviewed changes

src/release/breaking-changes/android-java-gradle-migration-guide.md Outdated Show resolved Hide resolved

timsneath reviewed Apr 6, 2023

View reviewed changes

parlough and others added 3 commits April 6, 2023 13:06

Merge branch 'main' into flamingo

83123fc

Update firebase.json

33a2975

Co-authored-by: Parker Lougheed <parlough@gmail.com>

Update src/release/breaking-changes/android-java-gradle-migration-gui…

df5d78e

…de.md Co-authored-by: Parker Lougheed <parlough@gmail.com>

ericwindmill approved these changes Apr 6, 2023

View reviewed changes

mariamhas previously requested changes Apr 6, 2023

View reviewed changes

reidbaker reviewed Apr 6, 2023

View reviewed changes

sfshaza2 added 2 commits April 6, 2023 15:36

Stashing

f167d05

More feedback

c5174e0

sfshaza2 force-pushed the flamingo branch from 796a26b to c5174e0 Compare April 6, 2023 22:54

tweak

df48f7c

reidbaker reviewed Apr 7, 2023

View reviewed changes

reidbaker approved these changes Apr 7, 2023

View reviewed changes

reidbaker mentioned this pull request Apr 7, 2023

[CP] Catch then clarify Java/gradle incompatibility error flutter/flutter#124403

Closed

Adding a note about 3.10

bdac710

timsneath approved these changes Apr 7, 2023

View reviewed changes

sfshaza2 merged commit c690914 into main Apr 7, 2023

sfshaza2 deleted the flamingo branch April 7, 2023 17:30

atsansone mentioned this pull request Jun 2, 2023

Explain incompatibility between Java versions #5871

Closed


		### Not yet released to stable

		* [Android Java Gradle migration guide][]

Adding a note about the Android Studio Flamingo gradle mismatch #8501

Adding a note about the Android Studio Flamingo gradle mismatch #8501

Uh oh!

Conversation

sfshaza2 commented Apr 6, 2023 • edited by parlough Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

khanhnwin commented Apr 6, 2023

Uh oh!

camsim99 commented Apr 6, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ericwindmill left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sfshaza2 commented Apr 6, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

timsneath left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

sfshaza2 commented Apr 6, 2023 •

edited by parlough

Loading