Skip to content

Add Overlay.of to 3.7 breaking changes #8188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sfshaza2 merged 1 commit into from
Jan 31, 2023
Merged

Add Overlay.of to 3.7 breaking changes #8188

sfshaza2 merged 1 commit into from
Jan 31, 2023

Conversation

@rydmike
Copy link
Contributor

@rydmike rydmike commented Jan 31, 2023

The Overlay.of breaking change is missing in 3.7 breaking changes doc page. It was done in a separate PR flutter/flutter#110811 earlier than the bulk of the other changes in flutter/flutter#114120

Description of what this PR is changing or adding, and why:

Adds missing breaking change in 3.7

Issues fixed by this PR (if any):

Presubmit checklist

@rydmike
Add Overlay.of to 3.7 breaking changes
d9c1fcb 
The `Overlay.of` breaking change is missing in 3.7 breaking changes doc page. It was done in a separate PR flutter/flutter#110811 earlier than the bulk of the other changes in flutter/flutter#114120
parlough
parlough approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks for adding this!

@rydmike
Copy link
Contributor Author

rydmike commented Jan 31, 2023

Thanks @parlough, it broke my code so it was hard to not miss it! 😄
Simple code fix of course, so no worries there.

However, generally I am a bit worried that this un-staged switch from nullable .of to none-nullable and addition of .maybeOf in one step might cause more problems with package dependencies than is being considered. They did so in the previous Flutter 2.0.0 case. Had a discussion about it here flutter/flutter#119499.

Not much to do about it anymore, ship sailed when stable was released without the staged approach briefly mentioned here: flutter/flutter#114120 (review).

Since the impacted APIs are less common than the ones in the 2.0.0 case I'm hopeful they will not have as a big fallout as they did in that case.

sfshaza2
sfshaza2 approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sfshaza2 sfshaza2 merged commit 76deba5 into flutter:main Jan 31, 2023
@Wouter12 Wouter12 mentioned this pull request Feb 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parlough parlough parlough approved these changes

@sfshaza2 sfshaza2 sfshaza2 approved these changes

@khanhnwin khanhnwin Awaiting requested review from khanhnwin

@domesticmouse domesticmouse Awaiting requested review from domesticmouse

@johnpryan johnpryan Awaiting requested review from johnpryan

@atsansone atsansone Awaiting requested review from atsansone

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The Overlay.of is missing from 3.7 list of breaking changes

3 participants

@rydmike @parlough @sfshaza2