Add examples on how to embed a Flutter screen into an existing SwiftUI app #7828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Ooh. I didn't mean to |
jmagman
reviewed
Nov 22, 2022
sfshaza2
reviewed
Nov 25, 2022
Contributor
sfshaza2
left a comment
There was a problem hiding this comment.
@leighajarett, I had very few minor nits, but I do agree with @jmagman's feedback - at least where I added a thumbs up. :D
Contributor
|
Once everything is resolved, it lgtm |
Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com> Co-authored-by: Jenn Magder <magder@google.com>
atsansone
suggested changes
Nov 28, 2022
Contributor
atsansone
left a comment
There was a problem hiding this comment.
@leighajarett : I noted some consistency and clarity issues here along with a few questions. In general, I would check:
- Use labels for variables that are not the same as the Object type.
- Clarify what code the comments are clarifying.
- Simplify some of the language.
I stopped my comments with the first instance of an issue. The comment would apply to any copy that has a similar issue (like variable names).
Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com>
atsansone
approved these changes
Dec 1, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what this PR is changing or adding, and why:
Developers are increasingly using SwiftUI, so it's important to show examples of how to embed Flutter into an existing SwiftUI app. I went through and tested the existing workflow and also added a few small things to project setup to make it easier, and to adapt to some new navigation within Xcode.
Issues fixed by this PR (if any): Fixes #7039 and #6998 and flutter/flutter#63051
Presubmit checklist