Skip to content

Add-to-app iOS flutter_post_install post_install documentation #7032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sfshaza2 merged 3 commits into from
Apr 15, 2022
Merged

Add-to-app iOS flutter_post_install post_install documentation #7032

sfshaza2 merged 3 commits into from
Apr 15, 2022

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Apr 14, 2022 •
edited
Loading

Description of what this PR is changing or adding, and why:
Add-to-app host Podfiles will be required to call flutter_post_install(installer) when flutter/flutter#101943 merges. The addition of defined?(flutter_post_install) will allow pod install to succeed on versions of Flutter that do not yet have flutter_post_install available.

Issues fixed by this PR (if any): None

Presubmit checklist

@jmagman jmagman self-assigned this Apr 14, 2022
@jmagman jmagman mentioned this pull request Apr 14, 2022
Merged
8 tasks
@jmagman jmagman marked this pull request as ready for review April 15, 2022 01:43
sfshaza2
sfshaza2 approved these changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a couple tweaks. I googled but couldn't find in what release that flutter_post_install was added, but couldn't find that info. Instead of saying "recently added" (which goes stale soon), I'd prefer to say in what release it was added.

@jmagman
Copy link
Member Author

jmagman commented Apr 15, 2022

I googled but couldn't find in what release that flutter_post_install was added, but couldn't find that info. Instead of saying "recently added" (which goes stale soon), I'd prefer to say in what release it was added.

flutter/flutter#101943 is in master but hasn't yet been tagged in a beta yet so it doesn't have a release number. I wrote the script so it will work on any version of Flutter, with or without that change.
I can:

  1. Hold off on this change until it reaches a beta
  2. Merge this now and update it this doc with the release number as soon as it gets tagged

@sfshaza2
Copy link
Contributor

sfshaza2 commented Apr 15, 2022

Great! Thanks for that info, Jenn. Let's merge it now!

@sfshaza2 sfshaza2 merged commit 97798d7 into flutter:main Apr 15, 2022
@jmagman jmagman deleted the flutter_post_install branch April 15, 2022 18:28
@jmagman jmagman mentioned this pull request Apr 15, 2022
Closed
@jmagman
Copy link
Member Author

jmagman commented Apr 15, 2022

Merge this now and update it this doc with the release number as soon as it gets tagged

Filed #7039 to track.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domesticmouse domesticmouse domesticmouse approved these changes

@sfshaza2 sfshaza2 sfshaza2 approved these changes

@khanhnwin khanhnwin Awaiting requested review from khanhnwin

@johnpryan johnpryan Awaiting requested review from johnpryan

Assignees

@jmagman jmagman

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmagman @sfshaza2 @domesticmouse