Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Apr 12, 2022

Description of what this PR is changing or adding, and why: Indicate that 32-bit iOS is now unsupported.

flutter/flutter#97341 just merged so it will technically still work until that hits stable, but it's certainly untested as of flutter/flutter#97385

Issues fixed by this PR (if any): Fixes #6729

Presubmit checklist

|Windows |Windows 7 |
|Linux |Debian & below |

We have dropped iOS8 support. For more information,
Copy link
Member Author

@jmagman jmagman Apr 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment and link make more sense in the Unsupported platforms section.

|--------|----------------------|
|Android |Android SDK 18 & below|
|iOS |iOS 8 & below |
|iOS |[iOS 8] & below and [`arm7v` 32-bit iOS]|
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully I did this link-in-table correctly...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks right. The link checker should complain if it's wrong.

PTAL @khanhnwin =)

@jmagman jmagman requested a review from zanderso April 12, 2022 22:18
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It lgtm to me!

Copy link
Contributor

@domesticmouse domesticmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@sfshaza2 sfshaza2 merged commit ca9b130 into flutter:main Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When 32-bit iOS support is removed from Flutter, update the Supported platforms list

4 participants