Skip to content

Page transitions replaced by ZoomPageTransitionsBuilder #6646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sfshaza2 merged 9 commits into from
Apr 7, 2022
Merged

Page transitions replaced by ZoomPageTransitionsBuilder #6646

sfshaza2 merged 9 commits into from
Apr 7, 2022

Conversation

@AlexV525
Copy link
Member

@AlexV525 AlexV525 commented Jan 10, 2022 •
edited
Loading

The breaking change note for flutter/flutter#100812.

Presubmit checklist

@AlexV525 AlexV525 requested review from Hixie and sfshaza2 January 10, 2022 02:25
@AlexV525 AlexV525 mentioned this pull request Jan 10, 2022
Closed
8 tasks
@AlexV525 AlexV525 changed the title ✨ Add breaking change note Page transitions replaced by ZoomPageTransitionsBuilder Jan 10, 2022
@AlexV525 AlexV525 requested a review from Hixie January 11, 2022 01:44
@AlexV525 AlexV525 requested a review from Hixie January 19, 2022 02:36
@Hixie
Copy link
Contributor

Hixie commented Jan 19, 2022

Learning more about the underlying PR, I think this doc needs to include the error message that happens when you find a Transform (or other widgets that we're introducing now), whereas previously you did not, and it should show how to fix it (e.g. using find.descendant).

@Hixie
Copy link
Contributor

Hixie commented Jan 19, 2022

(the idea of these docs is that people google error messages and we want to give them the answer as soon as they do so)

@AlexV525 AlexV525 marked this pull request as ready for review January 20, 2022 10:03
@AlexV525
Copy link
Member Author

AlexV525 commented Jan 20, 2022

I've added the tests migration and pointed out a few widgets related to this transition that might require migration.

domesticmouse
domesticmouse reviewed Jan 25, 2022
View reviewed changes
Copy link
Contributor

@domesticmouse domesticmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this LGTM, but I believe it should be held until after the next stable release.

@AlexV525 AlexV525 added the st.WIP Issue in progress label Jan 25, 2022
@domesticmouse
Copy link
Contributor

domesticmouse commented Jan 25, 2022

PTAL @sfshaza2

sfshaza2
sfshaza2 requested changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few grammatical edits and one clarification needed. thx!

@AlexV525 @sfshaza2
Apply suggestions from code review
94cb653 
Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
@AlexV525
Copy link
Member Author

AlexV525 commented Jan 27, 2022

Thanks @domesticmouse and @sfshaza2! The last step is to wait until the PR landed.

@AlexV525
Copy link
Member Author

AlexV525 commented Feb 8, 2022

(as per flutter/flutter#96375 (comment))

@AlexV525 AlexV525 mentioned this pull request Feb 16, 2022
Merged
8 tasks
@AlexV525 AlexV525 mentioned this pull request Mar 26, 2022
Merged
8 tasks
@AlexV525 AlexV525 force-pushed the breaking-zoom-page-transition branch from 61c586d to 94cb653 Compare March 26, 2022 04:15
@AlexV525
Merge branch 'main' into breaking-zoom-page-transition
8d405fd 
# Conflicts:
#	src/release/breaking-changes/index.md
@AlexV525
Copy link
Member Author

AlexV525 commented Mar 26, 2022 •
edited
Loading

The PR has been landed. Removing the WIP label for further review.

@AlexV525 AlexV525 removed the st.WIP Issue in progress label Mar 26, 2022
@AlexV525 AlexV525 requested review from sfshaza2 and removed request for kwalrath March 26, 2022 14:19
@AlexV525

This comment was marked as off-topic.

Sign in to view
AlexV525
AlexV525 commented Mar 31, 2022
View reviewed changes
@AlexV525

This comment was marked as off-topic.

Sign in to view
sfshaza2
sfshaza2 approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfshaza2 sfshaza2 merged commit aa9054e into flutter:main Apr 7, 2022
@AlexV525 AlexV525 deleted the breaking-zoom-page-transition branch April 7, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domesticmouse domesticmouse domesticmouse approved these changes

@sfshaza2 sfshaza2 sfshaza2 approved these changes

@Hixie Hixie Awaiting requested review from Hixie

@johnpryan johnpryan Awaiting requested review from johnpryan

@khanhnwin khanhnwin Awaiting requested review from khanhnwin

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AlexV525 @Hixie @domesticmouse @sfshaza2