Create mock-platform-channels.md #5322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
sfshaza2
reviewed
Feb 23, 2021
Contributor
sfshaza2
left a comment
There was a problem hiding this comment.
I can merge this once you remove this from draft status and add it to the index file.
Thx!
Contributor
|
@Hixie replied offline that it's not ready for merging. |
Contributor
Author
|
Let's wait a few days to see if flutter/flutter#76288 gets reverted (there's a high risk of that happening), but if it sticks, this is ready... |
Contributor
Author
|
It did; new PR is flutter/flutter#81235. |
Contributor
Author
|
I need to update this to mention that onPlatformMessage is no longer called. |
Contributor
Author
|
I should add something about tests that use |
Contributor
Author
|
Ok I think this is ready to land! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.