Skip to content

Add header migration guide#13457

Merged
chunhtai merged 3 commits into
flutter:mainfrom
chunhtai:header-break
Jun 3, 2026
Merged

Add header migration guide#13457
chunhtai merged 3 commits into
flutter:mainfrom
chunhtai:header-break

Conversation

@chunhtai

@chunhtai chunhtai commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

migration guide for flutter/flutter#186916

Presubmit checklist

  • If you are unwilling, or unable, to sign the CLA, even for a tiny, one-word PR, please file an issue instead of a PR.
  • If this PR is not meant to land until a future stable release, mark it as draft with an explanation.
  • This PR follows the Google Developer Documentation Style Guidelines—for example, it doesn't use i.e. or e.g., and it avoids I and we (first-person pronouns).
  • This PR uses semantic line breaks
    of 80 characters or fewer.

@chunhtai chunhtai requested review from a team and sfshaza2 as code owners June 2, 2026 18:22

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation for a breaking change regarding the update of semantics header and headingLevel behavior on iOS and Android, including a new markdown file and an update to the breaking changes index. Feedback on the changes points out extra blank lines in the index file and a conflicting ID reference in the references section where both an issue and a PR are listed with the same ID (175416).

Comment thread sites/docs/src/content/release/breaking-changes/index.md Outdated
Relevant PRs:

* [PR 186916][]
* [PR 175416][]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

GitHub issues and pull requests share the same ID sequence within a repository, meaning Issue 175416 and PR 175416 cannot both exist. One of these references is incorrect and should be updated to the correct ID (also update the corresponding link definition on line 119).

@flutter-website-bot

flutter-website-bot commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Staged preview of the updated docs.flutter.dev site (updated for commit ac0c429):

https://flutter-docs-prod--docs-pr13457-header-break-04943cj0.web.app

@parlough parlough left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me.

Feel free to land if it's ready. You can ignore the www-preview-bot failure.

@chunhtai chunhtai merged commit 0fa92b4 into flutter:main Jun 3, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants