-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Update Swift Package Manager pubspec.yaml syntax to use config section #12925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…section The `disable-swift-package-manager` field is deprecated. Update the documentation to use the new `flutter: config: enable-swift-package-manager` syntax introduced in flutter/flutter#168433. Also added a migration note to help users who were using the old syntax. Fixes flutter#12924
Summary of ChangesHello @dbebawy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Swift Package Manager documentation to align with the latest Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates the Swift Package Manager documentation to reflect the new pubspec.yaml configuration syntax. The change from the deprecated disable-swift-package-manager field to the config section is well-documented, and the addition of a migration note is a great improvement for user experience. I have one suggestion to align the formatting of the new note with the existing documentation style.
|
/gbcrun |
|
This looks good to me, but can you review, @vashworth? |
|
/gcbrun |
|
Visit the preview URL for this PR (updated for commit f8193a4): https://flutter-docs-prod--pr12925-fix-spm-pubspec-config-synt-pmakbupc.web.app |
|
Thanks, @dbebawy! |
sfshaza2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Updates the Swift Package Manager documentation to use the new
flutter: config:section format for pubspec.yaml configuration, replacing the deprecateddisable-swift-package-managerfield.Changes
File:
src/_includes/docs/swift-package-manager/how-to-enable-disable.mdBefore (deprecated)
After (current)
Additional Changes
Context
This change aligns the Swift Package Manager documentation with:
configsectionflutter: config:sectionTesting
src/content/tools/pubspec.mdRelated Issues
Fixes #12924
Pre-launch Checklist