Add a breaking change page for FontWeight handling of variable fonts #12615
Conversation
This adds documentation of the change made by flutter/flutter#175771
Summary of ChangesHello @jason-simmons, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces new documentation for a breaking change in Flutter that enhances how FontWeight interacts with variable fonts. The update streamlines font weight management by allowing FontWeight to directly control the weight attribute of variable fonts, expands the range of possible FontWeight values, and deprecates an older property, ultimately simplifying font styling for developers. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a new breaking change documentation page for FontWeight handling of variable fonts. The new page is well-written and clear. I've made a few suggestions to improve consistency and to make the migration guide more explicit for developers. Additionally, the index.md file has been updated, but the new entries are not in alphabetical order as stated in the document. I've added comments to point this out.
| ranging from 1 to 1000. This allows usage of weights beyond the | ||
| `FontWeight.w100` through `FontWeight.w900` range with values that are not | ||
| multiples of 100. This also means that linear interpolation of fonts using | ||
| `FontWeight.lerp` can yield values other than `FontWeight.w100` through `w900`. |
There was a problem hiding this comment.
I don't feel the need to add the class name here or in the next suggested change.
| * [`$FLUTTER_ROOT/version` replaced by `$FLUTTER_ROOT/bin/cache/flutter.version.json`][] | ||
| * [SnackBar with action no longer auto-dismisses][] | ||
| * [Deprecate `SemanticsProperties.focusable` and `SemanticsConfiguration.isFocusable`][] | ||
| * [`FontWeight` also controls the weight attribute of variable fonts][] |
There was a problem hiding this comment.
The documentation on line 35 states that this list is in alphabetical order. This new entry has been appended to the end of the list, but it should be placed alphabetically. Please insert it in the correct location to maintain the sort order.
There was a problem hiding this comment.
I don't have strong feelings about this one, either.
|
Visit the preview URL for this PR (updated for commit 5e3b957): https://flutter-docs-prod--pr12615-font-weight-breaking-kzvrybnk.web.app |
I'm ok with this change. Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
| ranging from 1 to 1000. This allows usage of weights beyond the | ||
| `FontWeight.w100` through `FontWeight.w900` range with values that are not | ||
| multiples of 100. This also means that linear interpolation of fonts using | ||
| `FontWeight.lerp` can yield values other than `FontWeight.w100` through `w900`. |
There was a problem hiding this comment.
I don't feel the need to add the class name here or in the next suggested change.
sfshaza2
left a comment
There was a problem hiding this comment.
lgtm. Most of the suggested changes aren't a bit deal to me, but the one "For example," addition does improve clarity.
This adds documentation of the change made by flutter/flutter#175771