Skip to content

Conversation

@QuncCccccc
Copy link
Contributor

This PR is to add a breaking change page for flutter/flutter#173084

Presubmit checklist

  • If you are unwilling, or unable, to sign the CLA, even for a tiny, one-word PR, please file an issue instead of a PR.
  • If this PR is not meant to land until a future stable release, mark it as draft with an explanation.
  • This PR follows the Google Developer Documentation Style Guidelines—for example, it doesn't use i.e. or e.g., and it avoids I and we (first-person pronouns).
  • This PR uses semantic line breaks
    of 80 characters or fewer.

@QuncCccccc QuncCccccc requested review from a team, antfitch, parlough and sfshaza2 as code owners August 19, 2025 22:44
@QuncCccccc QuncCccccc requested a review from chunhtai August 19, 2025 22:44
@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Aug 19, 2025

Visit the preview URL for this PR (updated for commit da2b39a):

https://flutter-docs-prod--pr12329-snackbar-with-action-ka0kloqm.web.app

Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor text cleanup. lgtm

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One potential tweak that I leave to you to judge. Otherwise, lgtm. Given that, I won't land this and leave it to you.

and remains on screen until manually dismissed by the user. When false, the
`SnackBar` auto-dismisses after its standard duration, regardless of the
presence of an action. When null, the `SnackBar` follows the default
behavior, which won't auto-dismiss if an action is present.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It rather saddens me that we add something to help with accessibility and then provide a way to undo it...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the original (wrong) behavior is corrected based on the current M3 specs but also breaking some existing apps. Developers may still want the original way and have more options to customize the behaviors.

…vior-update.md

Co-authored-by: Shams Zakhour <44418985+sfshaza2@users.noreply.github.com>
@sfshaza2 sfshaza2 merged commit 149eb52 into main Aug 25, 2025
9 checks passed
@sfshaza2 sfshaza2 deleted the snackbar_with_action branch August 25, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants