-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Migration guide for SnackBar default behavior with action #12329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Visit the preview URL for this PR (updated for commit da2b39a): https://flutter-docs-prod--pr12329-snackbar-with-action-ka0kloqm.web.app |
chunhtai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sfshaza2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor text cleanup. lgtm
src/content/release/breaking-changes/snackbar-with-action-behavior-update.md
Outdated
Show resolved
Hide resolved
src/content/release/breaking-changes/snackbar-with-action-behavior-update.md
Outdated
Show resolved
Hide resolved
sfshaza2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One potential tweak that I leave to you to judge. Otherwise, lgtm. Given that, I won't land this and leave it to you.
src/content/release/breaking-changes/snackbar-with-action-behavior-update.md
Outdated
Show resolved
Hide resolved
| and remains on screen until manually dismissed by the user. When false, the | ||
| `SnackBar` auto-dismisses after its standard duration, regardless of the | ||
| presence of an action. When null, the `SnackBar` follows the default | ||
| behavior, which won't auto-dismiss if an action is present. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It rather saddens me that we add something to help with accessibility and then provide a way to undo it...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the original (wrong) behavior is corrected based on the current M3 specs but also breaking some existing apps. Developers may still want the original way and have more options to customize the behaviors.
…vior-update.md Co-authored-by: Shams Zakhour <44418985+sfshaza2@users.noreply.github.com>
This PR is to add a breaking change page for flutter/flutter#173084
Presubmit checklist
of 80 characters or fewer.