Skip to content

Conversation

@QuncCccccc
Copy link
Contributor

This PR is to add a breaking change page for the update in the Material Theme system. Related to flutter/flutter#157292

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Feb 11, 2025

Visit the preview URL for this PR (updated for commit 2d2e023):

https://flutter-docs-prod--pr11707-material-theme-update-r3n26rf4.web.app

[Deprecate `ThemeData.indicatorColor` in favor of `TabBarThemeData.indicatorColor`]: /release/breaking-changes/deprecate-themedata-indicatorcolor
[`ImageFilter.blur` default tile mode automatic selection]: /release/breaking-changes/image-filter-blur-tilemode
[Localized messages are generated into source, not a synthetic package]: /release/breaking-changes/flutter-generate-i10n-source
[Material Theme System Updates]: /release/breaking-changes/material-theme-system-updates
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Material Theme System Updates]: /release/breaking-changes/material-theme-system-updates
[Material Theme System Updates - card, dialog & tab bar themes]: /release/breaking-changes/material-theme-system-updates

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suggested change will break the link and therefore the build.

@@ -0,0 +1,75 @@
---
title: Material Theme System Updates
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: Material Theme System Updates
title: Material Theme System Updates - card, dialog & tab bar themes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suggested change won't fix the build.

@sfshaza2
Copy link
Contributor

/gcbrun

@sfshaza2
Copy link
Contributor

/gcbrun

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfshaza2 sfshaza2 merged commit 6c75b32 into main Feb 11, 2025
9 checks passed
@sfshaza2 sfshaza2 deleted the material_theme_update branch February 11, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants