Skip to content

document how FLUTTER_BUILD_MODE is set during asset transformation #11510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sfshaza2 merged 2 commits into from
Dec 17, 2024
Merged

document how FLUTTER_BUILD_MODE is set during asset transformation #11510

sfshaza2 merged 2 commits into from
Dec 17, 2024

Conversation

@andrewkolos
Copy link
Contributor

@andrewkolos andrewkolos commented Dec 17, 2024 •
edited
Loading

Documents the feature long-ago implemented by flutter/flutter#144958.

Summary: this documents that asset-transforming Dart packages can read FLUTTER_BUILD_MODE from the environment to determine what mode the app is being built in. This also tries to fix what I think was a typo in the original docs.

If you are curious about what asset transformation is, read Assets and Images (flutter.dev) to learn how to bundle assets (arbitrary files, such as images) into your app and then read Asset transformation (flutter.dev).

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Dec 17, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 3931f9d):

https://flutter-docs-prod--pr11510-document-flutter-build-mode-jhzu19ln.web.app

@andrewkolos andrewkolos marked this pull request as ready for review December 17, 2024 17:53
@andrewkolos andrewkolos requested review from a team, parlough and sfshaza2 as code owners December 17, 2024 17:53
@andrewkolos andrewkolos requested a review from bkonyi December 17, 2024 17:53
sfshaza2
sfshaza2 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, @bkonyi! lgtm

@sfshaza2 sfshaza2 merged commit 4975760 into main Dec 17, 2024
9 checks passed
@sfshaza2 sfshaza2 deleted the document-flutter-build-mode-in-transformers branch December 17, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkonyi bkonyi bkonyi approved these changes

@sfshaza2 sfshaza2 sfshaza2 approved these changes

@parlough parlough Awaiting requested review from parlough

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewkolos @flutter-website-bot @bkonyi @sfshaza2