Skip to content

Migration guide for ThemeData.dialogBackgroundColor deprecation #11309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sfshaza2 merged 4 commits into from
Oct 24, 2024
Merged

Migration guide for ThemeData.dialogBackgroundColor deprecation #11309

sfshaza2 merged 4 commits into from
Oct 24, 2024

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Oct 23, 2024

Related to flutter/flutter#155072

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Oct 23, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 14742f6):

https://flutter-docs-prod--pr11309-deprecate-dialogbackgroundc-5udo1cp9.web.app

@TahaTesser TahaTesser mentioned this pull request Oct 23, 2024
Merged
9 tasks
@TahaTesser TahaTesser requested a review from QuncCccccc October 23, 2024 15:05
@TahaTesser TahaTesser marked this pull request as ready for review October 24, 2024 17:57
@TahaTesser TahaTesser requested review from a team, parlough and sfshaza2 as code owners October 24, 2024 17:57
@TahaTesser TahaTesser requested a review from Piinks October 24, 2024 17:57
@TahaTesser
Copy link
Member Author

TahaTesser commented Oct 24, 2024

Changed the status of this PR, now that flutter/flutter#155072 is landing.

sfshaza2
sfshaza2 approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, with a few grammatical fixes.

Piinks
Piinks approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfshaza2 sfshaza2 merged commit 8b346c1 into flutter:main Oct 24, 2024
@TahaTesser TahaTesser deleted the deprecate-dialogBackgroundColor branch October 25, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

@sfshaza2 sfshaza2 sfshaza2 approved these changes

@QuncCccccc QuncCccccc Awaiting requested review from QuncCccccc

@parlough parlough Awaiting requested review from parlough

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TahaTesser @flutter-website-bot @Piinks @sfshaza2