Skip to content

[web] Polish web embedding docs. #11133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ditman merged 7 commits into from
Sep 13, 2024
Merged

[web] Polish web embedding docs. #11133

ditman merged 7 commits into from
Sep 13, 2024

Conversation

@ditman
Copy link
Member

@ditman ditman commented Sep 13, 2024

During an internal walkthrough of the Web embedding documents, we came up with the following action items:

  • Document the need for the runWidget function
  • Rename "Full-screen" to "Full page"
  • Tweak the title to be smarter, "embedding" is not very meaningful

One of our users was also running the docs, and encountered some of the issues that this PR addresses:

There's also some minor typo/formatting fixes.

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@ditman ditman requested review from a team, parlough and sfshaza2 as code owners September 13, 2024 01:39
@ditman ditman requested a review from kevmoo September 13, 2024 01:42
@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Sep 13, 2024

Visit the preview URL for this PR (updated for commit 9c2134c):

https://flutter-docs-prod--pr11133-web-embedding-user-journey-v0hpre0e.web.app

@ditman
Copy link
Member Author

ditman commented Sep 13, 2024 •
edited
Loading

Thanks robot, here's the actual page that this PR is touching:

sfshaza2
sfshaza2 approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks so much, @ditman! Will wait for @kevmoo's review before landing.

kevmoo
kevmoo approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@ditman
Copy link
Member Author

ditman commented Sep 13, 2024

If both @sfshaza2 and @kevmoo are happy, I'm clicking the "Squash and merge" button right now.

Thanks for the quick review!

@ditman ditman merged commit 16573c2 into flutter:main Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevmoo kevmoo kevmoo approved these changes

@sfshaza2 sfshaza2 sfshaza2 approved these changes

@parlough parlough Awaiting requested review from parlough

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unexpected null value error appears when running multiView on Flutter Web

4 participants

@ditman @flutter-website-bot @kevmoo @sfshaza2