Skip to content

Clarify WillPopScope disables predictive back #10928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sfshaza2 merged 3 commits into from
Jul 22, 2024
Merged

Clarify WillPopScope disables predictive back #10928

sfshaza2 merged 3 commits into from
Jul 22, 2024

Conversation

@justinmc
Copy link
Contributor

@justinmc justinmc commented Jul 22, 2024

Make it clear that using WillPopScope does not support predictive back. In flutter/flutter#152057 (review) it was mentioned that this should be explicitly communicated in this breaking changes page.

Issues fixed by this PR (if any): n/a

PRs or commits this PR depends on (if any): flutter/flutter#152057

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@justinmc
Update android-predictive-back.md
cc238f0 
Make it clear that using WillPopScope does not support predictive back.
@justinmc justinmc mentioned this pull request Jul 22, 2024
Merged
@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Jul 22, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit f90ac5e):

https://flutter-docs-prod--pr10928-predictive-back-will-pop-sc-tkhriga2.web.app

@reidbaker reidbaker self-requested a review July 22, 2024 17:54
sfshaza2
sfshaza2 approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, with a couple minor edits. Thanks, @justinmc!

@sfshaza2 sfshaza2 merged commit 59f39d9 into main Jul 22, 2024
@sfshaza2 sfshaza2 deleted the predictive-back-will-pop-scope-clarification branch July 22, 2024 18:57
@justinmc
Copy link
Contributor Author

justinmc commented Jul 22, 2024

Thank you for the fixes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbaker reidbaker reidbaker approved these changes

@sfshaza2 sfshaza2 sfshaza2 approved these changes

@atsansone atsansone Awaiting requested review from atsansone

@parlough parlough Awaiting requested review from parlough

@domesticmouse domesticmouse Awaiting requested review from domesticmouse

@MaryaBelanger MaryaBelanger Awaiting requested review from MaryaBelanger

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@justinmc @flutter-website-bot @reidbaker @sfshaza2