Adding info on how to add privacy manifest to Cocopods #10920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Visit the preview URL for this PR (updated for commit e438615): |
domesticmouse
approved these changes
Jul 18, 2024
jmagman
reviewed
Jul 18, 2024
Comment on lines
507
to
508
| s.resource_bundles = {'shared_preferences_foundation_privacy' => ['shared_preferences_foundation/Sources/shared_preferences_foundation/Resources/PrivacyInfo.xcprivacy']} | ||
| ``` |
Member
There was a problem hiding this comment.
shared_preferences_foundation_privacy is the example from shared_preferences_foundation, maybe this should be
s.resource_bundles = {'your_plugin_privacy' => ['your_plugin/Sources/your_plugin/Resources/PrivacyInfo.xcprivacy']}or some appropriate placeholder?
stuartmorgan-g
approved these changes
Jul 19, 2024
Contributor
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM, thanks for doing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a note that we are eventually migrating to SPM.
Fixes #10864
cc: @jmagman @sethladd