Skip to content

[web] Change --web-renderer default from auto to canvaskit #10714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sfshaza2 merged 1 commit into from
Jun 6, 2024
Merged

[web] Change --web-renderer default from auto to canvaskit #10714

sfshaza2 merged 1 commit into from
Jun 6, 2024

Conversation

@mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Jun 6, 2024 •
edited
Loading

Changes the documentation of the default renderer on web. The default renderer is changing from auto to canvaskit.

This PR is mostly moving things around with no new content being added.

The PR making the code changes: flutter/flutter#149773
The issue: flutter/flutter#149826

Presubmit checklist

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Jun 6, 2024

Visit the preview URL for this PR (updated for commit 432b00a):

https://flutter-docs-prod--pr10714-mdebbar-patch-1-kwbt29kh.web.app

sfshaza2
sfshaza2 approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks, @mdebbar!

@sfshaza2 sfshaza2 merged commit e82c589 into main Jun 6, 2024
@sfshaza2 sfshaza2 deleted the mdebbar-patch-1 branch June 6, 2024 17:28
@mdebbar
Copy link
Contributor Author

mdebbar commented Jun 6, 2024

@sfshaza2 what's the timeline for deploying PRs to the live website?

This website PR shouldn't go live until the corresponding flutter PR lands in stable. What should I do to coordinate that?

@mdebbar
Copy link
Contributor Author

mdebbar commented Jun 6, 2024

@sfshaza2 what's the timeline for deploying PRs to the live website?

This website PR shouldn't go live until the corresponding flutter PR lands in stable. What should I do to coordinate that?

cc @parlough

@parlough parlough mentioned this pull request Jun 6, 2024
Merged
@parlough
Copy link
Member

parlough commented Jun 6, 2024

This website PR shouldn't go live until the corresponding flutter/flutter#149773 lands in stable. What should I do to coordinate that?

I've opened #10717 to revert/adjust these changes in the mean time.

Next time, feel free to open a PR in draft mode with a title like [3.25] Change --web-renderer default from auto to canvaskit or [Future] Change --web-renderer default from auto to canvaskit if the release is not determined yet. Just make sure the first text in the PR is "Blocked on landing in stable" or similar. If you don't update the PR once it lands in stable, we'll make sure it gets updated and landed.

I'll update some docs to make this more clear.

sfshaza2 pushed a commit that referenced this pull request Jun 6, 2024
@parlough
Adjustments after default renderer text merged too early (#10717)
6a9a66b 
Follow up to
#10714 (comment)
@mdebbar
Copy link
Contributor Author

mdebbar commented Jun 7, 2024

Thanks @parlough! I'll send a new PR with the [Future] prefix to make it clear that it shouldn't be merged yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfshaza2 sfshaza2 sfshaza2 approved these changes

@atsansone atsansone Awaiting requested review from atsansone

@parlough parlough Awaiting requested review from parlough

@domesticmouse domesticmouse Awaiting requested review from domesticmouse

@MaryaBelanger MaryaBelanger Awaiting requested review from MaryaBelanger

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mdebbar @flutter-website-bot @parlough @sfshaza2