Skip to content
This repository was archived by the owner on Nov 29, 2023. It is now read-only.

Conversation

@nturgut
Copy link
Contributor

@nturgut nturgut commented Feb 26, 2020

add flag install-only to install the driver without running it. Also add driver for chrome 78.

The possible ways of running the webdrivers:

dart lib/web_driver_installer.dart & (used in flutter/flutter. uses chromedrivers command. installs and runs the driver)

dart lib/web_driver_installer.dart chromedriver (not it use. installs and runs the chrome driver)

dart lib/web_driver_installer.dart chromedriver install-only (will be used in e2e package PR )

Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The possible ways of running the webdrivers:

dart lib/web_driver_installer.dart & (used in flutter/flutter. uses chromedrivers command. installs and runs the driver)

dart lib/web_driver_installer.dart chromedriver (not it use. installs and runs the chrome driver)

dart lib/web_driver_installer.dart chromedriver install-only

That sounds like fantastic documentation for the README.md file :P

@nturgut
Copy link
Contributor Author

nturgut commented Feb 26, 2020

The possible ways of running the webdrivers:

dart lib/web_driver_installer.dart & (used in flutter/flutter. uses chromedrivers command. installs and runs the driver)

dart lib/web_driver_installer.dart chromedriver (not it use. installs and runs the chrome driver)

dart lib/web_driver_installer.dart chromedriver install-only

That sounds like fantastic documentation for the README.md file :P

Done! Thanks for the suggestion

@nturgut nturgut merged commit 932f656 into flutter:master Feb 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants