Update zulip to use Color{,Swatch} asserts that tolerate float errors #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnprice
approved these changes
Sep 18, 2024
Member
gnprice
left a comment
There was a problem hiding this comment.
Thanks! LGTM assuming tests pass.
@gaaclarke FYI
Member
|
A lot of people are off at a conference, but I'll try to get it relanded tomorrow. Thanks. |
Member
|
Cool, sounds good. If you hit "approve" on this PR, then we can land this flutter/tests update to prepare for that. (I guess the GitHub UI is offering to let me merge it already. But I think the intended policy is that PRs here require two flutter-hackers approvals to merge, just like in the main Flutter repos, and we just haven't set things up to enforce that here.) |
gaaclarke
approved these changes
Sep 19, 2024
Member
|
Let's see if the autosubmit bot is active here… yep! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#155113.
This pulls in:
zulip/zulip-flutter@cdbe14122
zulip/zulip-flutter#949
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.