Skip to content

Conversation

@knopp
Copy link
Member

@knopp knopp commented Feb 25, 2024

super_sliver_list is an alternative to SliverList (and ListView) with different performance characteristics and ability to reliably jump / animate to any item.

It relies heavily on scrollOffsetCorrection in a way no other sliver in Flutter does and thus may be somewhat prone to breaking (for example it was broken in past by flutter/flutter#107735, which was reverted later).

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@knopp knopp force-pushed the add_super_sliver_list branch from 2eb99c0 to 6508862 Compare February 25, 2024 14:54
@knopp knopp force-pushed the add_super_sliver_list branch from 6508862 to 3adacbd Compare April 9, 2024 13:23
@parlough parlough requested a review from Piinks April 9, 2024 19:51
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for contributing these tests!

@auto-submit auto-submit bot merged commit f6b9c0a into flutter:main Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants