Skip to content

Remove flutter_reactive_ble test #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Oct 9, 2023
Merged

Remove flutter_reactive_ble test #300

auto-submit merged 1 commit into from
Oct 9, 2023

Conversation

@vashworth
Copy link
Contributor

@vashworth vashworth commented Oct 9, 2023 •
edited
Loading

Customer testing for flutter_reactive_ble was failing in CI, so we disabled it temporarily. However, we have not gotten a response from the owners in a while so removing it.

Fixes flutter/flutter#133483.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

stuartmorgan-g
stuartmorgan-g approved these changes Oct 9, 2023
View reviewed changes
Copy link

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auto-submit auto-submit bot merged commit e792a32 into flutter:main Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Assignees

No one assigned

Labels

autosubmit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Customer testing flutter_reactive_ble is failing in CI

2 participants

@vashworth @stuartmorgan-g