Skip to content

Updates reference for super_editor tests to the latest stable. #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Jun 28, 2023
Merged

Updates reference for super_editor tests to the latest stable. #277

auto-submit merged 2 commits into from
Jun 28, 2023

Conversation

@pdblasi-google
Copy link
Contributor

@pdblasi-google pdblasi-google commented Jun 28, 2023 •
edited
Loading

The most recent update on super_editor updates their dependency on golden_toolkit. The version previously being used referenced the deprecated TestWidgetsFlutterBinding.addTime method which caused failures on flutter #129663.

Working towards flutter #129654.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@pdblasi-google
Copy link
Contributor Author

pdblasi-google commented Jun 28, 2023

For reference, here's the diff between the old and new SHAs.

Flutter-Bounty-Hunters/super_editor@0e95507...869a572

HansMuller
HansMuller approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auto-submit auto-submit bot merged commit ff26a0e into flutter:main Jun 28, 2023
@pdblasi-google pdblasi-google deleted the issues/129654 branch June 28, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pdblasi-google @HansMuller